Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modify links action #974

Merged
merged 3 commits into from
Oct 28, 2024
Merged

Add modify links action #974

merged 3 commits into from
Oct 28, 2024

Conversation

girishpanchal30
Copy link
Contributor

Summary

In this PR, I've added modify links action to modify the <a></a> HTML attributes.

Screenshots

With Pro Version:
https://tinyurl.com/2ypn2944
https://tinyurl.com/23qrd67z

Without Pro version:
https://tinyurl.com/27xpoqg2
https://tinyurl.com/2b3gelle

Check before Pull Request is ready:

Closes https://github.com/Codeinwp/feedzy-rss-feeds-pro/issues/647

@girishpanchal30 girishpanchal30 added the pr-checklist-skip Allow this Pull Request to skip checklist. label Aug 29, 2024
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Aug 29, 2024
@pirate-bot
Copy link
Contributor

pirate-bot commented Aug 29, 2024

Plugin build for 08a424c is ready 🛎️!

@AndreeaCristinaRadacina

@girishpanchal30, thank you for taking care!

Here are my findings:

  • there are some weird characters appearing for certain parts of the content (those were not links before)
image
  • the panel doesn't have the same structure as in your screenshot:
    image

  • I set the links to open in the same tab and be nofollow, but this is not respected on the frontend:

image image

live behavior:
https://overdodevelopment.s1-tastewp.com/2024/08/30/8-mistakes-i-made-when-building-my-first-wordpress-plugin-using-ai-with-no-prior-development-experience/

@girishpanchal30
Copy link
Contributor Author

@AndreeaCristinaRadacina

there are some weird characters appearing for certain parts of the content (those were not links before)

Can you please share Feed URL?

the panel doesn't have the same structure as in your screenshot:

It could be a cache issue on your end; everything looks fine from my side.
Ref: https://tinyurl.com/25lj2l7p

@AndreeaCristinaRadacina
Copy link

@girishpanchal30 here is the feed: https://wpshout.com/feed

@girishpanchal30
Copy link
Contributor Author

@AndreeaCristinaRadacina I've fixed the mentioned issue with the latest commit.

@AndreeaCristinaRadacina
Copy link

@girishpanchal30 I am not sure why, but when using the Modify links action, the import no longer works:

image

Instance:

Also, from the previous comment (just making sure), have you checked this too?

I set the links to open in the same tab and be nofollow, but this is not respected on the frontend:

@girishpanchal30
Copy link
Contributor Author

@AndreeaCristinaRadacina It seems issue with PHP 8, now it fixed with the latest commit.

@AndreeaCristinaRadacina
Copy link

@girishpanchal30, great! It works as expected now. Thank you!

@vytisbulkevicius vytisbulkevicius merged commit 495d9f7 into development Oct 28, 2024
8 checks passed
@vytisbulkevicius vytisbulkevicius deleted the feat/pro/647 branch October 28, 2024 13:00
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 4.4.14 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants