Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow chained actions for [#item_title] #913

Merged
merged 16 commits into from
May 30, 2024

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Mar 29, 2024

Summary

Added the option to have chained actions for Post Title field in the Map Content on the tag [#item_title]. ( the process is similar to the one from post content)

Changes:

  • added tagify with the custom format for Post Title field that allow serialization for chained actions.
  • added [#item_title] in the list of allowed tags that can use the chained actions.
  • updated the data processing for $post_title to account for the new format.

If the user had some tags already in the title field, they will appear normal since they are saved like [#item_title], [#item_source].

The workflow:

  1. The import UI encodes all the chained actions data inside the Tagify action. (import-metabox-edit.js)
  2. On the import process, the field data is decoded and extracted from the tagify structure. (feedzy-rss-feeds-import.php)
  3. The structure is a serialized array with all the actions. The data field will be a mix of tags and normal text (if present).
  4. The tags are extracted from the entire field data. Then they are deserialized and processed.
  5. The result of the process is replaced in the field data (swaps the result with serialized data in the string).

Note

I did some code refactoring on the function and variable names so that the above process is reflected in their names.

Note

I removed the code from PR since they conflict. This version is more advance.

Will affect visual aspect of the product

NO

Screenshots

2024-03-29_18-48-20.mp4

Test instructions

Check before Pull Request is ready:

Closes https://github.com/Codeinwp/feedzy-rss-feeds-pro/issues/645

@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Mar 29, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review March 29, 2024 16:51
@pirate-bot
Copy link
Contributor

pirate-bot commented Mar 29, 2024

Plugin build for b987a2b is ready 🛎️!

@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Mar 29, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Apr 21, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as draft April 21, 2024 20:32
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review April 22, 2024 13:38
Copy link
Contributor

@preda-bogdan preda-bogdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will approve this even though I left a few small changes that maybe you can consider before proceeding.

includes/views/js/import-metabox-edit.js Outdated Show resolved Hide resolved
includes/views/js/import-metabox-edit.js Outdated Show resolved Hide resolved
Copy link
Contributor

@GrigoreMihai GrigoreMihai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not see other issues apart from what Bogdan mentioned.

@irinelenache
Copy link

irinelenache commented May 22, 2024

@Soare-Robert-Daniel

Can be checked here:

 Admin area URL: https://inexpensivegiraffe.s2-tastewp.com/wp-admin 
 Username: irinel 
 Password: 1vT9Vr7SHKQ 

@vytisbulkevicius vytisbulkevicius merged commit 3a06eb9 into development May 30, 2024
9 checks passed
@vytisbulkevicius vytisbulkevicius deleted the fix/title-with-chain-actions branch May 30, 2024 10:10
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 4.4.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants