Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-allow users to add magic tags to featured image #894

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Feb 26, 2024

Closes #893

Changes

  • Allow the user to add and edit their own custom tags.
  • Removed the mention of URL since the Fallback image feature does the same thing.

Screenshots

Feed Setting

image

Imported Post

image

Testing

Use a RSS feed that has images in a different tag other than image. You can the one from NASA: https://photojournal.jpl.nasa.gov/rss/index.html

The syntax for the custom tag is [#item_custom_<xml_tag>@<xml_attribute>]. ( In the case of the one from NASA, the xml_attributes is hiresJpeg without any attribute )

  1. Create a new feed import
  2. Add a feed that has images
  3. In the Map Content, on Featured Images, add a custom tag that extracts the image.
  4. Check if they are imported.

Note

Ensure images from the feed can be accessed; otherwise, you will get an importing error. Choose a good feed source.

Note

You will need developer/agency license

@pirate-bot
Copy link
Contributor

pirate-bot commented Feb 26, 2024

Plugin build for 601dc55 is ready 🛎️!

For adding images via URL, use fallback feature
@irinelenache
Copy link

@Soare-Robert-Daniel Tested and the issue is fixed now 👍

@Soare-Robert-Daniel Soare-Robert-Daniel merged commit fa82512 into development Mar 1, 2024
9 checks passed
@Soare-Robert-Daniel Soare-Robert-Daniel deleted the fix/url-tags-inside-featured-image branch March 1, 2024 15:46
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 4.4.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not able to use URL or other tags inside the featured image area
4 participants