Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store error logs for each import job #1038

Open
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

girishpanchal30
Copy link
Contributor

@girishpanchal30 girishpanchal30 commented Dec 19, 2024

Summary

Adds error log storing features.

Will affect visual aspect of the product

Yes

Screenshots

image

Test instructions

Option 1:
Activate a lower license plan and use higher plan magic tags in the import job.

Option 2:
Add the following code snippet to allow other error types:

add_filter(
	'feedzy_allowed_store_log_types',
	function ( $types ) {
		$types[] = 'debug'; // info, warn
		return $types;
	}
);

Users can disable the error storing feature by adding the following code snippet:

add_filter( 'feedzy_skip_store_error_logs', '__return_true' );

Check before Pull Request is ready:

Closes https://github.com/Codeinwp/feedzy-rss-feeds-pro/issues/701

@girishpanchal30 girishpanchal30 added the pr-checklist-skip Allow this Pull Request to skip checklist. label Dec 19, 2024
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Dec 19, 2024
@pirate-bot
Copy link
Contributor

pirate-bot commented Dec 19, 2024

Plugin build for 7d5875a is ready 🛎️!

@selul
Copy link
Contributor

selul commented Dec 19, 2024

@girishpanchal30 I think we need a way to limit this and store only the last ones, i.e let's say 200 logs. @vytisbulkevicius

Copy link
Member

@HardeepAsrani HardeepAsrani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We can limit the items as Marius mentioned, and maybe improve the styling a bit so it looks more readable. Also, they don't need to be red. They're not just errors.

@girishpanchal30
Copy link
Contributor Author

@HardeepAsrani I've applied both changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants