Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Icon): Add AlertFilledIcon #2999

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Conversation

katiezutter
Copy link
Contributor

@katiezutter katiezutter commented Dec 17, 2024

Overview

Adds AlertFilledIcon.

Screenshot 2024-12-17 at 7 19 09 PM

PR Checklist

  • Related to designs: Weekly Syllabus
  • Related to JIRA ticket: LEGO-4255
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Follow the testing instructions in https://github.com/codecademy-engineering/mono/pull/8863.

PR Links and Envs

Repository PR Link PR Env
Portal Portal Link Portal Env

@katiezutter katiezutter requested review from a team, JahazielGuzman and natalieweesh and removed request for a team December 17, 2024 18:04
Copy link

nx-cloud bot commented Dec 17, 2024

☁️ Nx Cloud Report

We didn't find any information for the current pull request with the commit d238a4a.
Please verify you are running the latest version of the NxCloud runner.

Check the Nx Cloud Source Control Integration documentation for more information.

Alternatively, you can contact us at [email protected].


Sent with 💌 from NxCloud.

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://6761bdd586ccd105bd1fc554--gamut-preview.netlify.app

Deploy Logs

@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]

@katiezutter katiezutter marked this pull request as ready for review January 6, 2025 15:57
@katiezutter katiezutter requested a review from a team as a code owner January 6, 2025 15:57
@katiezutter
Copy link
Contributor Author

@Codecademy/gamut hi! I'm not seeing the new icon show up in the storybook preview - wondering if there may be a step I'm missing!

Copy link
Contributor

@LinKCoding LinKCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked locally and the icon looks good in both light + dark mode —
at the moment, seems like the preview isn't reflecting the code changes for some reason (also saw this in another PR)

since it works locally and the alpha package works in the monorepo PR, will approve.

@katiezutter katiezutter added the Ship It :shipit: Automerge this PR when possible label Jan 6, 2025
@codecademydev codecademydev merged commit 098bb46 into main Jan 6, 2025
32 of 34 checks passed
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Jan 6, 2025
@codecademydev codecademydev deleted the kz-add-alert-filled-icon branch January 6, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants