162 repair validation #208
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w1stler
reviewed
Dec 3, 2025
Member
w1stler
left a comment
w1stler
left a comment
There was a problem hiding this comment.
- add commit with styling the code
.../widget/containers/main_body/content/application/application_tabs/applicants_tab/__init__.py
Outdated
Show resolved
Hide resolved
w1stler
approved these changes
Dec 3, 2025
Rafalkufel
requested changes
Dec 3, 2025
Contributor
Rafalkufel
left a comment
Rafalkufel
left a comment
There was a problem hiding this comment.
I think this part about validation are redundant. All others: good job 💪
Comment on lines
88
to
95
| # When showing the application container as part of UI flow we | ||
| # don't want to immediately highlight pristine fields. Use the | ||
| # internal _validate with show_errors=False to just check validity | ||
| # without triggering visual validation. Full validation (with | ||
| # highlights) will be triggered when user submits or switches tabs. | ||
| if hasattr(self.application_container, "_validate"): | ||
| return self.application_container._validate(show_errors=False) | ||
| # fallback |
Contributor
There was a problem hiding this comment.
Main task of this method is validate + highlight application, and all it's tabs. It should be called before we print documents. I don't think that adding another responsibility to it (ie show_errors=False) is correct.
Comment on lines
163
to
172
| # Backwards-compatible validate method. | ||
| # By default this behaves as before and will show field-level | ||
| # validation results. If called with show_errors=False it will | ||
| # only check `is_valid` flags (no display/highlighting) which is | ||
| # useful when toggling visibility of the application form so we | ||
| # don't highlight pristine fields immediately. | ||
| return self._validate(show_errors=True) | ||
|
|
||
| def _validate(self, show_errors: bool = True) -> bool: | ||
| """Internal validation helper. |
Contributor
There was a problem hiding this comment.
Generally we have:
- method
validateto mainly highlight errors of this component, and child components and additionally returns boolean of if given component is valid - property
is_validto only check if given component (and child components) is valid, without highlighting errors.
Your change tries to push this two into validate. Do we really need it?
| self.application_container = parent | ||
| layout = QVBoxLayout(self) | ||
| layout.setAlignment(Qt.AlignTop) | ||
| layout.setAlignment(Qt.AlignmentFlag.AlignTop) |
kabix09
force-pushed
the
feature/dev/162_repair_validation
branch
from
84131c7 to
b403d61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solve #162 issue.
Fix margins for headers and sections in "Create Application" tabs
Adjusted spacing to make headers and sections more aligned and readable.
Fix warnings overflowing tabs in the top navbar
Increased tab width so the ⚠ icon for invalid validation fits properly and does not overflow.
Fix initial validation in tabs
Form fields are no longer marked as validated when first entering the tab.
Fix sidebar menu button hover after resetting forms
After resetting forms, sidebar buttons now properly respond to hover.