Parametrize Factories to support different sessions + make memory-db proper fixture #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magul
force-pushed
the
stop-closing-db-session-mid-factory-creation
branch
from
b0c583f to
900b7d8
Compare
w1stler
reviewed
Jun 11, 2025
Member
w1stler
left a comment
w1stler
left a comment
There was a problem hiding this comment.
Let’s discuss offline. :)
PS we could run codespell on that repository to find spelling errors.
| def _rspo(self): | ||
| """ | ||
| As we encountered discrticts without any RSPO, instead of choosing random district | ||
| and then choosing random RSPO from that disctrict only, we shuffle district from provnce |
| """ | ||
| As we encountered discrticts without any RSPO, instead of choosing random district | ||
| and then choosing random RSPO from that disctrict only, we shuffle district from provnce | ||
| and then we settle with first district, that contains at least one RSOP. |
| @lazy_attribute | ||
| def meeting_time(self): | ||
| """ | ||
| Lets limit ourselelves to working hours and 5-minute increment. |
| if self.issue in [Issue.INDYWIDUALNE.value, Issue.INDYWIDUALNE_ROCZNE]: | ||
| return ( | ||
| f"{date.today().strftime(DATE_FORMAT)} -" | ||
| f" {faker.future_date(end_date=timedelta(weeks=50)).strftime(DATE_FORMAT)}" |
Member
There was a problem hiding this comment.
Please move that space to line above for improved readability. ;-)
magul
requested review from
a team
and removed request for
jacekkalbarczyk and
stanislawK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.