Adds option to disable in-game chat #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rampastring
reviewed
Aug 13, 2024
Comment on lines
+46
to
+56
| if (DisableChat) | ||
| { | ||
| for (int i = 0; i < countof(SessionClass_ChatEnabled); i++) | ||
| { | ||
| SessionClass_ChatEnabled[i] = false; | ||
| } | ||
| } |
There was a problem hiding this comment.
Is it necessary to re-assign these each frame? If not, a place other than the main loop would be more suitable.
Otherwise the code looks good.
There was a problem hiding this comment.
This is a "quick and dirty" solution to prevent user from re-enabling the chat from alliances menu. A TODO could be added for future reference about a better implementation, i.e. hooking the function that handles the chat toggle or the function called when exiting the alliances menu.
Rampastring
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #7
Adds option to disable in-game chat. If
DisableChat=True, the player cannot send or receive messages from others. The option can be set in spawn.ini (under "Settings" section) and RA2MD.ini (under "Options" section). Enabling the option in spawn.ini overrides the setting in RA2MD.ini even if explicitly set toFalse.