-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Game listings fetched by IRC List #570
Closed
Closed
Changes from 10 commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
aaa74bf
Add initial pass for fetching game listings with list & topic
GrantBartlett 031ae8d
Consistency on naming
GrantBartlett 8780cf6
Tidy up of checkbox checks
GrantBartlett f39bcef
Upon MOTD received, request channel list
GrantBartlett 4dc36b0
Add game list pattern to game collections
GrantBartlett 2617a2d
Doesn't seem needed
GrantBartlett c558641
Add way to find gamecollection by hosted channelname, e.g. #cncnet-yr…
GrantBartlett 9c2e6f4
PR feedback fixes
GrantBartlett a6e79aa
lblSupers to lblSuperWeapons
GrantBartlett 82ad89c
When the host closes a game, ensure we keep the ctcp capture to close…
GrantBartlett 4e06747
Remove duplicate
GrantBartlett 13e884e
Update tuple deconstructing
GrantBartlett 3e6ce20
Remove special hacks, LIST updates and topic setting
GrantBartlett 4ac8f24
Tidy
GrantBartlett 15b0cb4
Further tidy
GrantBartlett b319952
Add example topic
GrantBartlett 95cecfa
Operators at start of lines
GrantBartlett 1011c7d
Have a clear GAME and DETAIL section in the broadcast topic
GrantBartlett ef5c6ea
Hybrid ctcp/topic
GrantBartlett d103b50
Special topic irc message type
GrantBartlett 90c8c84
wip
GrantBartlett da7888e
wip
GrantBartlett aed6566
hybrid ctcp/topic handling
GrantBartlett 8ce1a68
Make sure we show the players in the room upon joining and not wait u…
GrantBartlett 3981ea1
Remove mapname from broadcasting topic
GrantBartlett 0e9acfa
Wip updates to ui processing
GrantBartlett c08e22a
Hosted game changes & user list updates
GrantBartlett 3cc60cc
Puts back other bits
GrantBartlett 2aaa180
Fix pipeline error
GrantBartlett a8913b2
Few ui fixes
GrantBartlett 0627385
Fixes to ui updating
GrantBartlett e73fb15
Update channel topic when player extra options updated
GrantBartlett e21bb2f
Remove our name if its in already in the topic
GrantBartlett b2e2882
No idea where this came from
GrantBartlett a5b2369
Pipeline build error fix
GrantBartlett 4eaa3a2
Tidy up of logs
GrantBartlett 61d915c
Tidy up
GrantBartlett fe09dad
Fix on topic change broadcasting player options
GrantBartlett File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same, the solution is hacky, which in this case also goes against the design (this is a distribution/game/mod icon, it can't change depending on a game mode). We would need to come up with a proper way to achieve what you want.
An option I see is:
0. Use both RA2/YR icon as
Texture
for CnCNet YR,EnabledIcon
andDisabledIcon
for INI defined game options, andIcon
for dropdown items,This way you could define ra2mode as broadcasted to cncnet lobby in INI, define enabled / disabled texture for it and it would change the "icon" of the game.