Game lobby extra panel improvements #484
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nightly build for this pull request:
|
Starkku
force-pushed
the
feature/extraoptions-panels
branch
from
0dc1fe5
to
dc6d2da
Compare
|
Since this PR has almost 1 year old I merged latest sources and this PR in a local repository for testing this variable $ToggleableControl that is mentioned in the main message and seems very useful. [GameLobbyBase]
...
$CC29=SuperWeaponsOptionsPanel:XNAExtraPanel ;PlayerExtraOptionsPanel
$CC30=btnSuperWeaponsOptionsOpen:XNAClientButtonThen: [btnSuperWeaponsOptionsOpen]
...
$ToggleableControl=SuperWeaponsOptionsPanel
[SuperWeaponsOptionsPanel]
$Width=400
$Height=200
$X=0
$Y=0; - LABEL_SPACING - DEFAULT_LBL_HEIGHT + 100
SolidColorBackgroundTexture=0,0,0,128
DrawMode=Stretched
BackgroundTexture=50.pngAnd works very well in this panel example :-D
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PlayerExtraOptionsPanelis now once againXNAPanelinstead ofXNAWindow. What this means is thatPlayerExtraOptionsPanel.iniis no longer read and the controls can now be customized in game lobby INIs (prefixed withPlayerExtraOptionsPanel_) and can use the dynamic properties fromINItializableWindowas well. For a quick migration, can simply port the contents ofPlayerExtraOptionsPanel.ini(if any) toGameLobbyBase.iniand prefix anyPlayerExtraOptionsPanelchild controls withPlayerExtraOptionsPanel_.$ToggleableControlonXNAClientButton& derivatives that are children ofINItializableWindow. What this does is make the button toggle visibility of said control. Only restrictions are that it won't work on the parent window itself and the target control must be fully initialized before the button (e.g the button or its parent(s) must be defined after the target or its parent(s) in the children list of[GameLobbyBase]or any other game lobby window control). Main use case would be additional panels for game options to conserve space where needed.