-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#368 show colors in color drop down #369
base: develop
Are you sure you want to change the base?
Conversation
Nightly build for this pull request:
|
51d39f1
to
d832813
Compare
@@ -17,6 +18,10 @@ public class MultiplayerColor | |||
|
|||
private static List<MultiplayerColor> colorList; | |||
|
|||
private static string randomColorLabel; | |||
|
|||
private static readonly string RandomColorDefaultLabel = "Random".L10N("UI:Main:RandomSide"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
private static readonly string RandomColorDefaultLabel = "Random".L10N("UI:Main:RandomSide"); | |
private static readonly string RandomColorDefaultLabel = "Random".L10N("UI:Main:RandomColor"); |
And also considering making this a readonly property to prevent L10N being called before loading the translation table (although it should works without being a property as long as the class is initialized after L10N initialized but it is not straightforward enough).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I understand. It is currently readonly
. Are you saying it shouldn't be readonly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch on the incorrect string.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I understand. It is currently
readonly
. Are you saying it shouldn't be readonly?
No. I mean changing =
to =>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahhhhh, I got it. Will do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
d832813
to
bbe0715
Compare
bbe0715
to
737d8e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Seeing the gap between the dropdown border and the color, it might be best if either a custom dropdown control was added that got rid of the gap, or I made the gap customizable in XNAUI. |
Decreased width of color drop down allows for increase of width of player name and side. Color drop down is now the same width as team and start drop downs.
Moved the "Random" label to an INI key.