Skip to content

Revert to .NET Framework #910

Revert to .NET Framework

Revert to .NET Framework #910

Triggered via pull request November 17, 2023 04:25
Status Success
Total duration 3m 9s
Artifacts 3

build.yml

on: pull_request
Matrix: build-clients
Fit to window
Zoom out
Zoom in

Annotations

30 warnings
build-clients (YR): ClientCore/ClientConfiguration.cs#L7
The using directive for 'System.Collections.Generic' appeared previously in this namespace
build-clients (YR): ClientCore/OSVersion.cs#L1
Declare types in namespaces (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1050)
build-clients (YR): ClientCore/Enums/AllowPrivateMessagesFromEnum.cs#L3
Rename type name AllowPrivateMessagesFromEnum so that it does not end in 'Enum' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1711)
build-clients (YR): ClientCore/SavedGameManager.cs#L15
Member 'saveRenameInProgress' is explicitly initialized to its default value (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1805)
build-clients (YR): ClientCore/CnCNet5/GameCollection.cs#L15
Rename type name GameCollection so that it does not end in 'Collection' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1711)
build-clients (YR): ClientCore/CnCNet5/NameValidator.cs#L24
Prefer 'AsSpan' over 'Substring' when span-based overloads are available (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1846)
build-clients (YR): ClientCore/ClientConfiguration.cs#L240
The behavior of 'int.ToString()' could vary based on the current user's locale settings. Replace this call in 'ClientConfiguration.GetThemeInfoFromIndex(int)' with a call to 'int.ToString(IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
build-clients (YR): ClientCore/CnCNet5/GameCollection.cs#L280
The behavior of 'string.StartsWith(string)' could vary based on the current user's locale settings. Replace this call in 'ClientCore.CnCNet5.GameCollection.GetIRCChannelNameFromIniFile(Rampastring.Tools.IniFile, string, string)' with a call to 'string.StartsWith(string, System.StringComparison)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1310)
build-clients (YR): ClientCore/CnCNet5/GameCollection.cs#L270
Member 'GetIRCChannelNameFromIniFile' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822)
build-clients (YR): ClientCore/ClientConfiguration.cs#L383
Member 'GetOperatingSystemVersion' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822)
build-clients (Ares): ClientCore/ClientConfiguration.cs#L7
The using directive for 'System.Collections.Generic' appeared previously in this namespace
build-clients (Ares): ClientCore/OSVersion.cs#L1
Declare types in namespaces (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1050)
build-clients (Ares): ClientCore/Enums/AllowPrivateMessagesFromEnum.cs#L3
Rename type name AllowPrivateMessagesFromEnum so that it does not end in 'Enum' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1711)
build-clients (Ares): ClientCore/CnCNet5/GameCollection.cs#L15
Rename type name GameCollection so that it does not end in 'Collection' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1711)
build-clients (Ares): ClientCore/SavedGameManager.cs#L15
Member 'saveRenameInProgress' is explicitly initialized to its default value (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1805)
build-clients (Ares): ClientCore/CnCNet5/NameValidator.cs#L24
Prefer 'AsSpan' over 'Substring' when span-based overloads are available (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1846)
build-clients (Ares): ClientCore/ClientConfiguration.cs#L240
The behavior of 'int.ToString()' could vary based on the current user's locale settings. Replace this call in 'ClientConfiguration.GetThemeInfoFromIndex(int)' with a call to 'int.ToString(IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
build-clients (Ares): ClientCore/CnCNet5/GameCollection.cs#L280
The behavior of 'string.StartsWith(string)' could vary based on the current user's locale settings. Replace this call in 'ClientCore.CnCNet5.GameCollection.GetIRCChannelNameFromIniFile(Rampastring.Tools.IniFile, string, string)' with a call to 'string.StartsWith(string, System.StringComparison)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1310)
build-clients (Ares): ClientCore/CnCNet5/GameCollection.cs#L270
Member 'GetIRCChannelNameFromIniFile' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822)
build-clients (Ares): ClientCore/ClientConfiguration.cs#L383
Member 'GetOperatingSystemVersion' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822)
build-clients (TS): ClientCore/ClientConfiguration.cs#L7
The using directive for 'System.Collections.Generic' appeared previously in this namespace
build-clients (TS): ClientCore/OSVersion.cs#L1
Declare types in namespaces (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1050)
build-clients (TS): ClientCore/Enums/AllowPrivateMessagesFromEnum.cs#L3
Rename type name AllowPrivateMessagesFromEnum so that it does not end in 'Enum' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1711)
build-clients (TS): ClientCore/CnCNet5/GameCollection.cs#L15
Rename type name GameCollection so that it does not end in 'Collection' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1711)
build-clients (TS): ClientCore/SavedGameManager.cs#L15
Member 'saveRenameInProgress' is explicitly initialized to its default value (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1805)
build-clients (TS): ClientCore/CnCNet5/NameValidator.cs#L24
Prefer 'AsSpan' over 'Substring' when span-based overloads are available (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1846)
build-clients (TS): ClientCore/ClientConfiguration.cs#L240
The behavior of 'int.ToString()' could vary based on the current user's locale settings. Replace this call in 'ClientConfiguration.GetThemeInfoFromIndex(int)' with a call to 'int.ToString(IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
build-clients (TS): ClientCore/CnCNet5/GameCollection.cs#L280
The behavior of 'string.StartsWith(string)' could vary based on the current user's locale settings. Replace this call in 'ClientCore.CnCNet5.GameCollection.GetIRCChannelNameFromIniFile(Rampastring.Tools.IniFile, string, string)' with a call to 'string.StartsWith(string, System.StringComparison)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1310)
build-clients (TS): ClientCore/CnCNet5/GameCollection.cs#L270
Member 'GetIRCChannelNameFromIniFile' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822)
build-clients (TS): ClientCore/ClientConfiguration.cs#L383
Member 'GetOperatingSystemVersion' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822)

Artifacts

Produced during runtime
Name Size
artifacts-Ares Expired
42.9 MB
artifacts-TS Expired
42.9 MB
artifacts-YR Expired
42.9 MB