Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smoothing out the animation. #254

Closed
wants to merge 2 commits into from
Closed

Smoothing out the animation. #254

wants to merge 2 commits into from

Conversation

gjones
Copy link
Collaborator

@gjones gjones commented Nov 30, 2023

Summary

This PR adds transition to the major components. Don't worry, its set down at 100ms and we can reduce the token easily if we get complaints that its too much.

@gjones gjones requested a review from vineethasok November 30, 2023 21:49
Copy link

vercel bot commented Nov 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
click-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 1, 2023 10:48am

@gjones
Copy link
Collaborator Author

gjones commented Nov 30, 2023

Note: this pr can't be merged until after #252 due to changes in tokens.

Copy link
Collaborator

@vineethasok vineethasok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we should not allow all transition as default
Sometimes we don't want animation on color change but on width change this could cause some issue

@gjones
Copy link
Collaborator Author

gjones commented Dec 1, 2023

Alright, good point, I'll close this for now and figure out a better way to introduce transitions.

@gjones gjones closed this Dec 1, 2023
@gjones gjones deleted the gj-transition branch December 1, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants