Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MoM] Feral psion updates with copy-from #77259

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented Oct 22, 2024

Summary

Mods "[MoM] Feral psion updates with copy-from"

Purpose of change

Copy-from makes sure that it's easier to keep monsters that are supposed to be similar up to date, preventing idiosyncrasies. For example, a lot of feral psions had dodge 3 (feral default is 1), weird vision ranges (feral security guard, Ψ Division had vision 35, better than the 30 that ferals used to have but worse than the 45 they have now), armor they shouldn't have (feral telekinetics still had their innate armor even though they get Momentum Alteration and some get Inertial Barrier now), and so on. If ferals are even further changed, this will keep feral psions in sync.

Describe the solution

Copy-from chain all feral psions to mon_feral_psion_default, which itself is copy-from mon_feral_human_pipe (one remove done to set base flags and special attacks once instead of per-monster, since many feral psions don't use weapons or throw rocks). Delete all redundant lines, use proportional and relative when necessary.

Describe alternatives you've considered

Testing

WIP

Additional context

Feral electrokinetics and biokinetics still have their speed boosts. It's out of scope for this PR, but they should get Heightened Reflexes/Neuro-Acceleration as appropriate, so you can lead them toward blanks to cancel their buffs (or use a null grenade once I add those).

@Standing-Storm Standing-Storm marked this pull request as draft October 22, 2024 17:01
@Karol1223
Copy link
Contributor

I don't normally review mod PRs but I just wanted to say I really appreciate how Dr. Brain's extend field is larger than some vanilla monster files

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Monsters Monsters both friendly and unfriendly. Mods: Mind Over Matter astyled astyled PR, label is assigned by github actions labels Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions [JSON] Changes (can be) made in JSON Mods: Mind Over Matter Mods Issues related to mods or modding Monsters Monsters both friendly and unfriendly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants