Aftershock: Remove swims flag from terrestrial creatures.

[John-Candlebury]

Summary

Mods "Aftershock: Remove swims flag from terrestrial creatures."

Purpose of change

Describe the solution

SWIMS flag does slow down monsters in land, which is a balance discussion for another day, but I't doesnt really make sense for this terrestian creatures to have it.

[Karol1223]

SWIMS flag does slow down monsters in land

Seriously? If it actually does, please document this if you can. I was not aware of that.

[John-Candlebury]

SWIMS flag does slow down monsters in land

Seriously? If it actually does, please document this if you can. I was not aware of that.

Yeah if you check monster::calc_movecost swimming monsters pay the full movecost of their current map tile and the full cost of their destination tile when moving. Normal monsters just pay half of each.

I'm actually not sure if this is the intended behavior or not. It's certainly not documented.

[Karol1223]

I'm actually not sure if this is the intended behavior or not. It's certainly not documented.

It seems not to be, frankly, given the documentation only says they're supposed to treat water as a 50 movecost terrain. Does it at least do as advertised?

[John-Candlebury]

Yeah water to water is exactly 50 cost.

[IdleSol]

Cataclysm-DDA/src/monmove.cpp

Lines 1522 to 1523 in 8f226e5

	const int source_cost = here.move_cost( f );
	const int dest_cost = here.move_cost( t );

Cataclysm-DDA/src/monmove.cpp

Lines 1528 to 1538 in 8f226e5

	} else if( swims() ) {
	if( here.has_flag( ter_furn_flag::TFLAG_SWIMMABLE, f ) ) {
	movecost += 25;
	} else {
	movecost += 50 * here.move_cost( f );
	}
	if( here.has_flag( ter_furn_flag::TFLAG_SWIMMABLE, t ) ) {
	movecost += 25;
	} else {
	movecost += 50 * here.move_cost( t );
	}

If I understand this correctly. For tiles without SWIMMABLE flag, the total move_cost is equal to:

move_cost = 0 + 50 * here.move_cost( f ) + movecost + 50 * here.move_cost( t )

And if it didn't have a SWIMS flag, then:

Cataclysm-DDA/src/monmove.cpp

Lines 1564 to 1566 in 8f226e5

	} else {
	movecost = ( ( 50 * source_cost ) + ( 50 * dest_cost ) ) / 2.0;
	}

P.S. Do we have furniture with the SWIMMABLE flag?