Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fragile and Sturdy flags cannot be inherited #77256

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

John-Candlebury
Copy link
Member

Summary

Bugfixes "Fragile and Sturdy flags cannot be inherited"

Purpose of change

Fixes: #75163

And overall it doesnt make sense for the base item to ever become fragile/sturdy when you attach items to it.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Oct 22, 2024
@RedMisao

This comment was marked as outdated.

@Karol1223
Copy link
Contributor

I do not see why limiting the compatibility of the flags with copy-from is the way to go instead of solving the problem where it actually is a problem through the use of delete syntax.

@Procyonae
Copy link
Contributor

You could potentially make it so that extending with sturdy/fragile removes the other (or some general form of that for conflicting flags) would be fine but just removing inheritance from stuff isn't cool

@John-Candlebury
Copy link
Member Author

John-Candlebury commented Oct 22, 2024

Oh this affects only the behaviour of the "inherits_flags" pocket setting, as when you mount a NVG unit to an army helmet. "copy-from" functionality wont be affected by this.

@RedMisao
Copy link
Contributor

Modded the inherit line to check if a item B being a copy-from item A with FRAGILE inherited the flag, and it does.
Most importantly, it is already documented to work for attachments/pockets, my bad.

@John-Candlebury
Copy link
Member Author

No worries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aftershock light exosuit frame gets damaged in combat
4 participants