Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exodii weaponmaster #77255

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

GuardianDll
Copy link
Member

Summary

None

Purpose of change

People tie too much stuff to hub 01; i don't like it
also i don't like that there is too little npcs in rocky butte

Describe the solution

add weaponmaster that partially handles weapon and armor trade; maybe in future they could do more, but man i'd rather yell at code for a week than make npc

Describe alternatives you've considered

remove it's merchant abilities, just making them vibin' here

Testing

TBD

Additional context

perfect counterpart to untranslateable dialogues of Rubik

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display astyled astyled PR, label is assigned by github actions labels Oct 22, 2024
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • &Still completely mute, it shows you something you completely missed: The entire wall behind the workbench was full of various weapons: some as big as modern rifles, a few as large as machineguns installed on aircraft, and one that looked like dismantled tank turrets. Melee weapons were not left behind, from moderate-sized swords and clubs to warhammers twice the human height and what you can describe only as "boots for mecha". Then it pointed to the sign near you that showed the carved pictograms of coins, some unknown for you sign, and then a bullet - all things considered, it is either a weaponmaster or a weapon merchant.
  • &Weaponmaster seems to clean some weapon, but as you approach them, they call someone to pick a gun, and turn to you.
  • &Weaponmaster seems to polish some armor, but turn to you the second you enter the room.
  • &Weaponmaster seems to tinkering something, but turned their chair to you as you approached.
  • &You pull off your backpack, and start to pull different stuff you deem worthy of trading. The weaponmaster finally looks interested.
  • Weaponmaster
  • Who-… Wha-… What are you?

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Oct 22, 2024
"id": "TALK_WEAPONMASTER_INTRO_1",
"type": "talk_topic",
"//": "mute by choise, and deaf most of the time (don't like to turn on the hearing cbm unless for job)",
"dynamic_line": "&What you see looks like the back of a mechanical spider, with at least a dozen crude but polished metal arms going from the enormously wide spine and shoulders. Spine of a creature, meanwhile, sits in an awkward-looking chair, doing something on a wide, heavily lighted workbench. Creature seems to be busy with something.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

polished metal arms going from -> >polished metal arms coming from

Spine of a creature
I think you are referencing the mechanical spider's spine here in which case this should be
The spine of the creature

wide, heavily lighted
This should probably be changed to
wide, brightly lit
but if you wanted you could leave heavily in place of brightly. Lighted is also correct, and more popular in British English, so this one is subjective.

Creature seems to be -> >The creature seems to be

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

choise -> choice

{
"id": "TALK_WEAPONMASTER_INTRO_2A",
"type": "talk_topic",
"dynamic_line": "&It doesn't react at your presence at all.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't react at your -> >It doesn't react to your

@John-Candlebury
Copy link
Member

Oh cool stuff.

{
"id": "TALK_WEAPONMASTER_INTRO_3",
"type": "talk_topic",
"dynamic_line": "&A few seconds later, they seem to finish whatever they were busy with and slowly turn their chair to you. Their front looks no less exotic than their back; the abundance of metal arms looks even more extraordinary next to the clear lack of any legs. What you initially thought to be a chair is simply a rotating platform, sturdy enough to support the weight of the entire body of a creature. Few cameras, that seems to be a replacement for eyes, look at you motionlessly, while the forehead of the creature has the surprisingly familiar sign \"IX\" painted on.",
Copy link
Contributor

@AudBobb AudBobb Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

turn their chair to you -> >turn their chair towards you
entire body of a creature -> >entire body of the creature

Few cameras, that seems to be a -> >A number of cameras, which seem to be a

{
"id": "TALK_WEAPONMASTER_INTRO_4",
"type": "talk_topic",
"dynamic_line": "&Still completely mute, it shows you something you completely missed: The entire wall behind the workbench was full of various weapons: some as big as modern rifles, a few as large as machineguns installed on aircraft, and one that looked like dismantled tank turrets. Melee weapons were not left behind, from moderate-sized swords and clubs to warhammers twice the human height and what you can describe only as \"boots for mecha\". Then it pointed to the sign near you that showed the carved pictograms of coins, some unknown for you sign, and then a bullet - all things considered, it is either a weaponmaster or a weapon merchant.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole thing needs to be restructured

Still completely mute, it shows you something you had initially missed. The entire wall behind the workbench is full of various weapons; some as big as modern rifles, a few as large as the machine guns installed on aircraft, and one that looks like a dismantled tank turret. Melee weapons were not forgotten, from moderately-sized swords and clubs to war hammers twice the height of a human, and what you can describe only as "boots for mecha". Then it points to a sign near you that shows the carved pictograms of coins, some unknown to you, next to a pictogram of a bullet - all things considered, this creature is either a weapons master or a weapons merchant.

"dynamic_line": "&They clearly do not understand you. It seems they do not hear you either.",
"responses": [
{
"text": "&You pull off your backpack, and start to pull different stuff you deem worthy of trading. The weaponmaster finally looks interested.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pull different stuff you deem -> >pull out items you deem

"id": "TALK_EXODII_WEAPONMASTER",
"type": "talk_topic",
"dynamic_line": [
"&Weaponmaster seems to tinkering something, but turned their chair to you as you approached.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Weapons Master seems to be tinkering on something, but turns their chair to you as you approach.

"type": "talk_topic",
"dynamic_line": [
"&Weaponmaster seems to tinkering something, but turned their chair to you as you approached.",
"&Weaponmaster seems to clean some weapon, but as you approach them, they call someone to pick a gun, and turn to you.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Weapons Master seems to be cleaning some sort of weapon, but as you approach them, they call out to someone to take the weapon, and turn to you.

I believe your meaning of this >they call someone to pick a gun< is the weapon master is calling someone to take the weapon they were working on back to the armory or something along those lines, so I corrected the grammar under that assumption.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the Exodii would use sound, but rather radio, especially if sound receivers are typically disabled.

"dynamic_line": [
"&Weaponmaster seems to tinkering something, but turned their chair to you as you approached.",
"&Weaponmaster seems to clean some weapon, but as you approach them, they call someone to pick a gun, and turn to you.",
"&Weaponmaster seems to polish some armor, but turn to you the second you enter the room."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Weapons Master seems to be polishing some armor, but they turn towards you the second you enter the room.

],
"responses": [
{
"text": "&With familiar move, you take off different valuables on the trader counter, proposing a trade.",
Copy link
Contributor

@AudBobb AudBobb Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With a familiar movement, you place a variety of valuables onto the counter, proposing a trade.

@AudBobb
Copy link
Contributor

AudBobb commented Oct 22, 2024

That's all the grammar issues I see, seems like a good addition to the exodii to try and make them more interesting! Interesting concept for the NPC too, I look forward to trading with spider man.

@PatrikLundell
Copy link
Contributor

If Rubik won't trade certain stuff he'd probably need dialog to direct you to the appropriate trader(s), with the message that they don't understand Anglic, so you'd have to communicate using gestures.
One thing you could do is to use Rubik's dialog to tell you the names of them so you could have one dialog start where you call the name of the one you address, and one for a general "Hello there". You could also have introductions, one for when you know the name of your counterpart (only presenting yourself), and one for when you make a general call and your counterpart introduces itself first and you thereafter (automatically, unless you want a rude alternative, which I wouldn't provide if I tried to write it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants