Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting duration for all types of prying, not only for prying nails #77252

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Night-Pryanik
Copy link
Contributor

Summary

None

Purpose of change

Implement @LyranRenegade's suggestion from #59045.

Describe the solution

Previously one was able to set duration for prying, though he had to set prying_nails: true despite not even planning to actually pry nails. duration field name was confusing since it's not "duration of prying", but rather "duration of prying nails".

Now duration field works regardless of state of prying nails, one only need to set duration to anything greater than 1 second.

Describe alternatives you've considered

Change field name from duration to something like prying_nails_duration to avoid confusion. But adding functionality is still better, I think.

Testing

Added duration: 300 seconds to locked wood door. Tried to pry it with a crowbar. Noticed that prying took 5 minutes instead of usual ~30 seconds for a default character.

Additional context

None.

@Night-Pryanik Night-Pryanik added [C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style labels Oct 22, 2024
@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [Markdown] Markdown issues and PRs json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Oct 22, 2024
@github-actions github-actions bot added Code: Tests Measurement, self-control, statistics, balancing. BasicBuildPassed This PR builds correctly, label assigned by github actions labels Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style Code: Tests Measurement, self-control, statistics, balancing. <Documentation> Design documents, internal info, guides and help. json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant