Print message for failed prying attempt regardless of whether terrain/furniture has breakable defined
#77251
+14
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e` field isn't defined for furniture/terrain Instead, make all calculations for bashing furniture/terrain on failure only if `breakable` field is defined, and print failure message regardless of that check.
Night-Pryanik
added
[C++]
github-actions
bot
added
astyled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Describe the solution
Do not exit early from
handle_failurefunction ifbreakablefield is not defined for furniture/terrain. Instead, make all calculations for bashing furniture/terrain on failure conduct only ifbreakablefield is defined, and print failure message regardless of that check.Describe alternatives you've considered
None.
Testing
Made my character 1 strength. Got a crowbar. Spawned closed coffin. Tried to pry it. Got a
You pry, but the coffin remains closed.message on failure.Additional context
None.