Forbid starting fires on water tiles #77250
Open
+12
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[C++]
|
This is out of scope here but given the fact #76366 made liquid tiles configurable it might make sense to have a flag like |
|
Yes, good idea. |
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Forbid starting fires (using firestarters) on water tiles"
Purpose of change
If you start fire in water no matter shallow or deep - it will burn and cannot be extinguishedstatement from that issue on latest experimental as of 22 October 2024, I suppose not allowing to start a fire with help of firestarters on water tile is enough to close the issue.Describe the solution
Forbid starting fires (using firestarters) on water tiles. Also added a separate message for trying to start a fire on water.
Describe alternatives you've considered
Also forbid creating fire fields on water tiles through other means, for example flamethrowers, molotovs and magic?
Testing
Got a lighter and some splintered wood. Put the wood on tiles with shallow and deep water. Tried to light a fire on those tiles.
Additional context
None.