Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes the hoodie pocket from cropped hoodies #77249

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Sirbab
Copy link
Contributor

@Sirbab Sirbab commented Oct 22, 2024

Summary

Bugfixes "Removes the pockets flag from the cropped hoodies"

Purpose of change

Given cropped hoodies have the part of the hoodie where the kangaroo pocket removed, it doesn't make sense you could warm your hands in one.

Describe the solution

Adds a delete entry for the pockets flag on cropped hoodies.

Describe alternatives you've considered

Leaving the magic hand warming pocket on cropped hoodies.

Testing

Booted my testing save, spawned a cropped hoodie, looked at description and verified it lacked the pockets flag.
Tested on:

  • OS: Windows
    • OS Version: 10.0.19045.4894 (22H2)
  • Game Version: cdda-experimental-2024-10-21-2303 7fc0414 [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Portal Storms Ignore NPCs [personal_portal_storms],
    Slowdown Fungal Growth [no_fungal_growth]
    ]

Additional context

image

Adds a delete entry to cropped hoodies for the pockets flag, as they physically lack the area where the kangaroo pocket is.
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Items: Armor / Clothing Armor and clothing <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant