Add Brass Catchers Slots to HWP and Prototype Gun #77248
Draft
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a brass catcher slot to the HWP and Prototype gun, as that is very likely an oversight to be missing.
github-actions
bot
added
[JSON]
|
The HWP is based off of the FN2000, which has a forward ejection port. There is a comment about the lack of a slot for it, https://github.com/CleverRaven/Cataclysm-DDA/blob/cdda-experimental-2024-10-22-0120/data/json/items/gun/robofac_gun.json#L26. |
Ah, I missed that. Thanks holli. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Features "Adds Brass Catcher Slots to HWP and Prototype Gun"
Purpose of change
Both the HWP and Prototype gun lacked a slot for brass catchers, which honestly doesn't make sense given the triviality of adding a bag to a gun. GuardianDLL checked for me, and there was no comment about the lack of the slot, so we assumed it was simply an oversight.
Describe the solution
Adds a slot for brass catcher to each gun. Easy, simple.
Describe alternatives you've considered
Not adding a mod slot to these guns, because they're too high tech or something.
Testing
Booted the game up with changes, worked just fine. Spawned a HWP and Prototype gun, added a bore mod to each (as mod slots are invisible without these), and found a slot. Spawned two brass catchers and attached one to each gun.
Tested on the following version and settings
Dark Days Ahead [dda],
Disable NPC Needs [no_npc_food],
Portal Storms Ignore NPCs [personal_portal_storms],
Slowdown Fungal Growth [no_fungal_growth]
]
Additional context