math: implement assignment operators #77238
Open
+407
−418
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
The math parser enforces an expression split in 1/2/3 strings as a design choice, in order to get neat(-ish) line breaks for long expressions. In practice though, most expressions are short and this design choice leads to a mess of commas and quotation marks.
Describe the solution
Store intermediary function nodes as prototypes and only resolve them when operators/parens/eof/whatever are resolved.
Add assignment operators.
Reduce the eoc-math glue to a glorified string concatenator.
In practice this means that:
Instead of this:
you can write this:
(it was already possible for comparison operators)
but you can also split it into as many strings as you want for the purpose of clarity or whatever:
TODO:
Describe alternatives you've considered
N/A
Testing
Test units
Additional context
N/A