math: improve diag_value constructors #77228
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
diag_value
anddiag_kwargs
are a little awkward to useDescribe the solution
Add more constructors so you can use arithmetic values and string literals directly
Instead of
you can now write
Instead of
you can now write
diag_value type( PICKUP_RANGE );
Instead of
you can now write
and they are treated as zero/null values as needed.
You can also easily construct arrays now
Add a `kwarg_or()` helper function
Instead of
you can now write
Works with empty values too
diag_value type = kwargs.kwarg_or( "type" );
Describe alternatives you've considered
N/A
Testing
Existing test units
Additional context
GuardianDll take a look please and let me know if this is clear.