Set owner for new appliances #77211
Open
Set owner for new appliances #77211
+12
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
<Bugfix>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "New appliances have correct owner"
Purpose of change
Newly created appliances belong to NULL faction currently, until the player grabs them. With no owner, they can't be used for zone binding.
Fixes #77209
Describe the solution
Set the owner of newly created appliances to the [faction of the] character that [took the last step of the process that] created them.
Describe alternatives you've considered
place_appliance could return the vehicle, then the caller could decide if and how to set the owner, but this was suggested against on Discord.
Testing
I've tested the case described in the linked issue and the bug is gone. There's no obvious misbehavior when creating wiring, but I can't find a game mechanic that confirms the ownership either. I haven't been able to test the other two cases.
Additional context