Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parametrize carpets in basement nests #77210

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Milopetilo
Copy link
Contributor

@Milopetilo Milopetilo commented Oct 21, 2024

Summary

Content "Basement nest carpets have variation"

Purpose of change

I thought nests always having the same color of carpet becomes a bit bland over time, so made it so carpets can have different colors. If more carpets ever get added it will also be easier to add them.

Describe the solution

Added a new palette standard_domestic_carpet_palette and apply where relevant. I tried to avoid changing out areas where the carpet was chosen for aesthetic reasons, or at least seemed like it was.

Describe alternatives you've considered

Not do this and always have the same carpets

Testing

Game loads, carpets change, furniture has correct flooring, carpets which shouldn't change don't.

Additional context

I had a lot of trouble with the parameter here because it only seems to work with "scope": "nest", I'm unsure if I did something wrong or this is intended.
I'm also planning on looking over most of the other nests and maybe buildings in general, but in order to keep the size of the pr down I thought I'd get this one out first.
Draft for now since #77208 needs to merge first

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Oct 21, 2024
@Milopetilo Milopetilo marked this pull request as ready for review October 21, 2024 13:53
@Maleclypse
Copy link
Member

Thank you for doing this. Parametrizing stuff makes a huge difference in how the game looks and feels.

@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Oct 21, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants