party toilet only for flushing illegal stuff #77086
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move charge check to check_consistency(), return default count to (1,1), remove Item_spawn_data::finalize()
The source of the explosion for grenades was being passed as the character they were (potentially) on, because no other character was available to be responsible at that point. To make a character available, whenever an item is activated or thrown, set an item var with the last character to do so on it. Then, use that to find the explosion source. Also, ignore it in checking if an item stacks with another.
When you can smash something, but it will be difficult, you need to repeatedly press 's' and then a direction key. This is tiresome, and there's no real reason for it - we can just ask the player if they want their character to keep smashing until it's gone. Move noninteractive bashing code for avatars into an avatar:: function, and return some info about how the bash went - if it didn't succeed but could with more effort, ask if they want to keep bashing until it does. Also fix types for a bashing debug message.
-dialogue debug menu picks NPCs correctly from the list
github-actions
bot
added
[JSON]
Karol1223
suggested changes
Oct 16, 2024
data/json/itemgroups/stashes.json
Outdated
| "type": "item_group", | ||
| "id": "stash_drugs_illegals", | ||
| "items": [ | ||
| { "prob": 5, "group": "melatonin_tablet_bottle_plastic_pill_supplement_1_30" }, |
There was a problem hiding this comment.
Why is like the most normal sleep medication in the universe in a group with illegal drugs
|
If people were flushing drugs down the toilets you wouldn't be able to find them, as they'd be flushed away. However, if they hid it in the toilet tanks in some kind of water proof containers it would make some kind of sense (the "sense" being that police would be too ignorant or, more probably, lazy or subject to accepting incentives, to look in such obvious hiding spots). |
…-bugfix Cache dialogue conditional results, fix dialogue hotkeys
…ems it's charging (CleverRaven#77059) * Initial commit * >0 (no divide by zero) * We love janky solutions to get around integer limits * Linting
…ills Track kills through grenades and other explosives
…-overload [Aftershock] Fix incorrect EoC name
…xt-fix Fixed issue where extra cursor was drawn in ImGui InputText field on TUI builds erroneously
github-actions
bot
added
the
BasicBuildPassed
* Update zinosaur_upgrade.json * Update zinosaur_upgrade.json
…verRaven#77081) * Initial commit * Missed adding 1 afs_
Allow any grade of steel chunk for the makeshift hammer
Option to start bash activity on partial bash
* Add spell * Add spell scroll * Add spell components * Add goodberry item * Add spell scroll * Add scroll * Add dabbler hobby * Update data/mods/Magiclysm/Spells/druid.json Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update data/mods/Magiclysm/items/ethereal_items.json Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Updates --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
CleverRaven#77063) * Removed several skin mutations that previously prohibited installation of Alloy Plating CBM * Changes names of Alloy Plating bionics
Spawn emergency drugs in pharmacy, update quests text
[Aftershock] Fix electron overflow energy cost
Remove code for auto derivation of count-max
…Cataclysm-DDA into only-illegals-flushing
github-actions
bot
added
NPC / Factions
|
huh why github. why did you do that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
mr harakka suggested this, and I chose to pick it up. After further deliberation, it turned into removing stuff that didn't make sense to hide
Describe the solution
New "stash_drugs_illegals" itemgroup for use in private resort toilets. I am keeping in tobacco pipes and glass pipes (bongs) because I guess they would be able to be crushed and flushed, and the party people didn't want the police to find traces.
Describe alternatives you've considered
Testing
Added various debug items to the itemgroup in question to know that the private resort toilets (like in picture) are the ones currently being changed, then removed said debug items along with all other nonsensical items after making sure by seeing. Then did a non-exhaustive test to see that weird legals aren't spawning.
Additional context
Please correct me on missing illegal stuff and potentially kept legal stuff, I only made very shallow searches.