Use an enum to specify overmap tile see cost instead of a number #75432
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Infrastructure "Specify see_cost for overmap terrain with an enum instead of an integer"
Purpose of change
5e1c99a fixes an accident made in e44c61f
Following #75236, overmap vision needs adjustment. Using an enum makes it easier to tweak and tune the system, as the categories correspond to physical characteristics of the overmap terrains and what numeric values they correspond to can be swiftly tweaked.
Describe the solution
Replace all instances of
see_cost": [0-9]
with an enum. Add the enum and handling for it, and update documentation."all_clear"
"none"
"low"
"medium"
"spaced_high"
"high"
"full_high"
"opaque"
Describe alternatives you've considered
More or different enum values could be used.
Testing
The game loads with all mods enabled, and overmap vision works as expected.