Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make EXOTIC HWP resemble a LMG #75281

Merged
merged 7 commits into from
Jul 31, 2024
Merged

Conversation

SirPendrak
Copy link
Contributor

@SirPendrak SirPendrak commented Jul 27, 2024

Summary

Balance "Increase weight of HWP EXOTIC configuration and give integrated bipod"

Purpose of change

This thing was too light, and baisicaly unusuable at full auto

Describe the solution

Give it some more weight and bipod as well as threaded muzzle for mounting muzzle brake, compensator etc.

Describe alternatives you've considered

Ideally, this would come with build in both bipod and muzzle brake, but because of how BIPOD flag works on single gunmod, effects of muzzle brake would be lost when firing this thing from shoulder

Make the bipod foldable but that was little benefit for more work

Testing

Tested

Additional context

None

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves labels Jul 27, 2024
Copy link
Contributor

You are creating a pull request with the master branch as the head branch. This is likely a mistake unless you really know what you are doing. You may read https://docs.github.com/en/get-started/quickstart/contributing-to-projects#creating-a-branch-to-work-on for a typical workflow of contributing to a project on GitHub.

@github-actions github-actions bot added Game: Balance Balancing of (existing) in-game features. json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jul 27, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jul 28, 2024
@kevingranade
Copy link
Member

I'm not following your rationale. This is a hub-designed weapons platform that has a bunch of configurations. You bring them ammo samples and they make you a bolt/barrel(/maybe receiver?) parts kit to convert it to the new calibre. It seems to be positioned as a LMG in this configuration so 5-round burst makes sense to me, and I definitely don't see a reason to override BombasticSlacks' choice here.

@SirPendrak
Copy link
Contributor Author

I understand that original author had his vision, and I try to respect that by proposing change to something I believe was an oversight.
In robofac_gun file there is a comment saying it is based on EXODI BR, so model 71., one that has only semi and 2 burst fire mode.
You dont get this conversion by bringing just ammo, you have to bring mag and one of two rifles. Both rifles have 2 round burst mode. Only LMG model 68. has full auto.
Another topic is that HWP chambered in 12.3 ln weights only 3,7 kg when you remove sights, and 3,5kg if we dont count integrated forward grip and laser sight. It is the largest caliber avaliable to it, probably closer to .30-06 than .308. Why is it getting higher rate of fire than every other HWP configuration? How is the super-light barrel not melting? IRL guns of similar role usually weight arround 8kg (BAR) or 6kg (H-car), but thats semi-auto only.
I know that HUB scientist can sometimes get too creative, but they are not total idiots, and recoil of this caliber on such lightweight platform while full-auto is enormous, making it useless, save for bursting shoggoths at point blank range

If this rationale is not enough, I will close this PR

@SirPendrak
Copy link
Contributor Author

Changed the dialogue mentioning it accepting standard EXODI mags. I had two options:

  1. Make it accept both EXODI and HUB mags.
  2. Change the dialogue.
    Other caliber conversion of HWP always use HUB-made mags, so I chosen option 2

@kevingranade
Copy link
Member

kevingranade commented Jul 31, 2024

Another topic is that HWP chambered in 12.3 ln weights only 3,7 kg when you remove sights,

Ok, since that's such a dominant concern maybe bump the weight up a bit. That seems far more likely to be the oversight than the rate of fire.

IRL guns of similar role usually weight arround 8kg (BAR) or 6kg (H-car), but thats semi-auto only.

Looking over https://en.wikipedia.org/wiki/Light_machine_gun that's not what I'm seeing. If you focus on the older ones yea they're heavy as hell, but more modern stuff like the RPK are down around 5kg. Even lower for more modern intermediate cartridges, but yea that makes it hard to do apples-apples because they're losing some weight because of modern materials, design goals etc and some because they're just chasing smaller cartridges.

@SirPendrak SirPendrak changed the title Give EXOTIC HWP BURST 2 instead of AUTO 5 Make EXOTIC HWP resemble a LMG Jul 31, 2024
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jul 31, 2024
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • A Hub 01 Hybrid Weapons Platform quick swap conversion kit. This version has a heavy barrel with an integrated bipod, threaded muzzle and "EXODIC" stamped into the metal. The typo appears to be intentional.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@SirPendrak
Copy link
Contributor Author

Ok, so now i am semi-happy with this version, and i think bipod is something that truly transforms this gun into LMG.
I had some problems when i tried to make this one BORE gunmod include both bipod and barrel/muzzle gunmods, baisicaly they were not working when BIPOD flag was present and gun was fired from shoulder.

This conversion still fits into HWP maitenance kit, but barerly

@kevingranade
Copy link
Member

Works for me! I think this is what they call synthesis.

@kevingranade kevingranade merged commit 3ae095f into CleverRaven:master Jul 31, 2024
25 checks passed
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Game: Balance Balancing of (existing) in-game features. Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants