Stop iteminfo test from failing w/ mod damage types #75278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Code: Tests
ehughsbaird
force-pushed
the
better-iteminfo-test
branch
from
c1297b9
to
9382538
Compare
github-actions
bot
added
the
BasicBuildPassed
When mods add additional damage types, additional data is added to the iteminfo strings, making testing for the whole string fail. But we can instead test for the specific damage types and the coverage header that we're testing for, and the test will no longer fail with additional damage types. A Beak bodypart is also added by the test mod, changing the protection of some items.
Now that it's no longer checking the whole message, we can get back some of the strictness that was lost by checking it's at least in increasing order.
ehughsbaird
force-pushed
the
better-iteminfo-test
branch
from
9382538
to
c740cce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
This test is failing on every PR, as tests are run with mods that add additional damage types.
Describe the solution
We can instead test for the specific damage types and the coverage header that we're testing for, and the test will no longer fail with additional damage types.
Testing
tests/cata_test --mods=dda,magiclysm 'Armor_values_preserved_after_copy-from,armor_protection'Additional context
I think this is a clear message, but it will be a lot of text when it fails.
