Treat bleeding from pets #75274
Merged
Treat bleeding from pets #75274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Easy way to treat the bleeding of a pet -Add message when bleeding stops
github-actions
bot
added
the
[C++]
Better style Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions
bot
added
json-styled
|
Finally!! I have been hoping for someone to take on this since the PR from Maleclypse was closed! Long live our pet overlords! |
github-actions
bot
added
the
astyled
Solve error with message: Error: /home/runner/work/Cataclysm-DDA/Cataclysm-DDA/src/monexamine.cpp:58:1: error: string_id declarations should be sorted. [cata-static-string_id-constants,-warnings-as-errors] /home/runner/work/Cataclysm-DDA/Cataclysm-DDA/src/monexamine.cpp:58:1: note: 'effect_bleed' should be before 'effect_tied'.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions
bot
added
astyled
|
I'm a bit confused with the check failing. Anyone know what could be wrong?
|
|
That failure isn't yours. Clang and all the required tests passed so you should be good on this. |
|
Why have this been merged without even basic proofreading? |
By default assume it's something we lack. The tests in general seem to be outdated in many places. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Features "Add option to make the bleeding of a pet stop"
Purpose of change
In the game until now, when a pet starts bleeding, we have no option to stop it using bandages or other meds that stop the bleeding effect.
This was tried to be solved by @Maleclypse in this PR #62216, but was unfinished and moved to Abandoned but Desired PRs
Describe the solution
I wanted something easy to solve the problem.
In case we don't have an item in hand or the item cannot be used to stop the bleeding, a message pops up in the log
Describe alternatives you've considered
There were other options I considered:
I chose the option implemented because it was the easiest one and could make the work without complications or make the pet die while the player is making the healing.
Testing
I did manual testing, summoning a pet and making him bleed. After that, I tried:
I wanted to create some tests to automate this, but I was a bit confused when I found there's no tests in the test folder related to examine a pet (Swap, saddle, rename, etc.).
Because I don't know if this is a decision or something we lack, I just wanted to wait and maybe create the tests in a different PR
Additional context