Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Survivor Hood and Cowl Changes + Cowls Can Use Filters #75255

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

Kantonine
Copy link
Contributor

Summary

Balance "Survivor hood kevlar changes, and Cowl rebalancing"

Purpose of change

This is one follow-up to #74188, where I talked about some of the changes that should be done to armor. This specific Pr is to help rebalance both survivor hoods and cowls (mainly cowls) to help make them more useful for average gameplay. It was also annoying to see one major item that hadn't yet been updated for the modern system.

Describe the solution

I gave the Scavenger (now mercenary cowl) and Nomad cowls the same filtration effect that filtration masks use, requiring the use of filter cartridges to bolster the environmental protection, while also adding missing proficiencies to both recipes for the nomad cowl. Before, Cowls were in a weird spot not really useful for much. I also readjusted the crafting recipes for a majority of the survivor hoods, and the mercenary cowl to omit ballistic kevlar usage.

Describe alternatives you've considered

I did think about not adding the filtration effect, but if its only for smoke, then theres still plenty of things that can still bleed through the cowls.

Testing

Tested this many times to ensure that my json was up to scratch, big shoutout to ThatFanficGuy on the community Discord who helped me out with this!

Additional context

Untitled
Inspo for the scav/mercenary cowl, the OKZK cap

Fixes #74218

I replaced all mentions of "kevlar_layered" in the survivor hoods with just "kevlar", as well as adding filter mask cartridge use with both nomad and scavenger cowl, with the scavenger cowl now being renamed to mercenary cowl in-game (I didn't touch the ID for the item, as I'd rather avoid messing up all the ids for tileset reference, and crafting recipes)
Added millinery and plasticworking proficiencies to the nomad cowl recipe
Added filter mask requirement to nomad cowl crafting recipes
Cowl crafting recipes adjusted to omit kevlar, and to add more choices to craft, also added relevant crafting proficiencies too. if anyone else wants to try and simplify this a bit, they can
Replaced all mention of ballistic kevlar with sheet kevlar, sans h20 hoods and masks due to considered obsoletion of survivor wetsuit items
Fixed itty bitty json error
Recipe Linting
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Items: Armor / Clothing Armor and clothing <Bugfix> This is a fix for a bug (or closes open issue) Game: Balance Balancing of (existing) in-game features. astyled astyled PR, label is assigned by github actions labels Jul 26, 2024
@marilynias
Copy link
Contributor

Are you still on this?

@Kantonine
Copy link
Contributor Author

Are you still on this?

If I can, I'll try and get this done this weekend

Kantonine and others added 6 commits October 15, 2024 09:11
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Game: Balance Balancing of (existing) in-game features. Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scavengers cowl does not accept filters
2 participants