Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pluralize and unify offal naming #75252

Merged
merged 2 commits into from
Jul 27, 2024
Merged

Conversation

Karol1223
Copy link
Contributor

@Karol1223 Karol1223 commented Jul 26, 2024

Summary

None

Purpose of change

On the devcord someone posted a screenshot of butchery results, where every piece of offal was in multiple and none of them save for lungs were pluralized. I was annoyed by this and went on an adventure.

Describe the solution

  • Renamed all offal to be piece of [offal] so it sounds more natural
  • Renamed all marrow items to be portion of bone marrow for the same reason
  • Allowed some mollusk dishes and smoked lobster to pluralize
  • Made the tainted chunk of fat follow fat naming scheme

Describe alternatives you've considered

Not doing this? I am not a native english speaker, and it's entirely possible I made it worse with this PR. I'm gonna need some feedback

Testing

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Jul 26, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jul 26, 2024
@Maleclypse Maleclypse merged commit e3c29e2 into CleverRaven:master Jul 27, 2024
26 checks passed
@Karol1223 Karol1223 deleted the naming branch July 27, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants