Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obsolete Dire Wolves #75241

Merged
merged 5 commits into from
Jul 28, 2024
Merged

Conversation

Karol1223
Copy link
Contributor

@Karol1223 Karol1223 commented Jul 25, 2024

Summary

None

Purpose of change

They were completely unused anywhere in the repo save for one shotgun test and one filler Backrooms mongroup. Not to mention they no longer really make sense to keep in vanilla, as wolves are restricted to small populations in zoos and in #74554 I outlined why allowing large vertebrates to mutate is problematic

Describe the solution

Destroy

Describe alternatives you've considered

Testing

Additional context

Huge shout out to Megafauna for both including additional spawns for this monster and then blacklisting it so it can't spawn

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Spawn Creatures, items, vehicles, locations appearing on map Code: Tests Measurement, self-control, statistics, balancing. [C++] Changes (can be) made in C++. Previously named `Code` Monsters Monsters both friendly and unfriendly. Mods: Magiclysm Anything to do with the Magiclysm mod Mechanics: Enchantments / Spells Enchantments and spells Mods: TropiCataclysm 🌴 Having to do with the tropical region mod for DDA. Mods: Xedra Evolved Anything to do with Xedra Evolved Mods: Mind Over Matter Mods: Backrooms json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jul 25, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jul 27, 2024
@SirPendrak
Copy link
Contributor

Game ballance doc has one line mentioning direwolves:
Monster melee dice size scaling:
Maximum dice size for balance purposes: 12 (hardest possible hitter; dire wolf )

@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [Markdown] Markdown issues and PRs labels Jul 28, 2024
@Maleclypse Maleclypse merged commit 67026ae into CleverRaven:master Jul 28, 2024
27 of 28 checks passed
@Karol1223 Karol1223 deleted the destroy-dire-wolves branch July 28, 2024 19:07
@LyranRenegade
Copy link
Contributor

hmm I use one in my mod which hasn't been released yet.
Don't know why you would remove things that aren't in the way of anything..

@Karol1223
Copy link
Contributor Author

Karol1223 commented Aug 1, 2024

hmm I use one in my mod which hasn't been released yet.
Don't know why you would remove things that aren't in the way of anything..

If it doesn't have a reason to exist, it has a reason not to. Unused content is still maintenance burden - has to be translated, has to be updated during bigger monster syntax changes (like armor last year or so), ends up being accounted for in things like modded blacklists or XE vampire spells, or ends up used as useless (because they don't occur ingame anyway) examples in documentation.

If you use it in your mod, feel free to add it back to your mod, but it's not any reason to keep it in vanilla.

@LyranRenegade
Copy link
Contributor

ok yeah I get that..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Code: Tests Measurement, self-control, statistics, balancing. <Documentation> Design documents, internal info, guides and help. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs Mechanics: Enchantments / Spells Enchantments and spells Mods: Backrooms Mods: Magiclysm Anything to do with the Magiclysm mod Mods: Mind Over Matter Mods: TropiCataclysm 🌴 Having to do with the tropical region mod for DDA. Mods: Xedra Evolved Anything to do with Xedra Evolved Mods Issues related to mods or modding Monsters Monsters both friendly and unfriendly. Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants