Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Xedra Evolved ] Dream wounds: Shadows #74678

Merged
merged 40 commits into from
Aug 18, 2024

Conversation

Maleclypse
Copy link
Member

@Maleclypse Maleclypse commented Jun 19, 2024

Summary

Mods "XE Dreamwounds: Locations for spell item drops"

Purpose of change

Eliminating spell drops from offices and basic houses.

Describe the solution

Creates locations for spell drops to make sense in game.

Describe alternatives you've considered

So many.

Testing

Tested and all errors removed.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Spawn Creatures, items, vehicles, locations appearing on map Monsters Monsters both friendly and unfriendly. Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Mechanics: Enchantments / Spells Enchantments and spells Mods: Xedra Evolved Anything to do with Xedra Evolved astyled astyled PR, label is assigned by github actions labels Jun 19, 2024
@github-actions github-actions bot added the Map / Mapgen Overmap, Mapgen, Map extras, Map display label Jun 19, 2024
@Maleclypse Maleclypse marked this pull request as ready for review July 18, 2024 02:17
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions and removed json-styled JSON lint passed, label assigned by github actions labels Jul 18, 2024
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Jul 24, 2024
@github-actions github-actions bot added the Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves label Jul 24, 2024
@github-actions github-actions bot added BasicBuildPassed This PR builds correctly, label assigned by github actions Items: Food / Vitamins Comestibles and drinks json-styled JSON lint passed, label assigned by github actions and removed json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jul 26, 2024
@Maleclypse
Copy link
Member Author

File renamed to avoid load order bug #75332

@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 9, 2024
@SariusSkelrets
Copy link
Contributor

Would the shadow banish spell affect these shadows too? It would make it more useful as it only works against three monsters currently

@Maleclypse
Copy link
Member Author

Would the shadow banish spell affect these shadows too? It would make it more useful as it only works against three monsters currently

I'll think about it. My eventual plan was for these to be the way you gained the eater class which means unless you started as an eater you'd never have banish when meeting these.

So like riddle dream, end question asks what class you want to become, you select eater, it spawns this map extra and gives you a mission to go to it. You get your first eater spell from dropping the quickling shadow. Though I guess I've already added stuff making these best as a more common enemy. Hmm. I'd add an extra effect to the banish spell that checks for these shadow monsters, declares them to resist the banishment and does lesser damage to them based on your spell level capping at like 60% of health.

@dseguin dseguin merged commit 0b29941 into CleverRaven:master Aug 18, 2024
18 of 24 checks passed
@Maleclypse Maleclypse deleted the Dream-Wounds branch September 7, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Items: Food / Vitamins Comestibles and drinks [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display Mechanics: Enchantments / Spells Enchantments and spells Mods: Xedra Evolved Anything to do with Xedra Evolved Mods Issues related to mods or modding Monsters Monsters both friendly and unfriendly. Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants