Fixing broken text on ImTui when building with cmake #73413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Code: Build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "fixing cmake build so that text is not garbled on curses builds in imgui screens"
Purpose of change
Fixes an issue where all ImGui screens show all text as squiggles (literally the ~ character) and all the sizes of everything is very broken
Describe the solution
Added -DIMTUI to src/third-party CMakeLists.txt to fix broken text in imgui
Describe alternatives you've considered
Testing
Open the keybindings screen from the main menu and verify that the screen shows without the text being all garbled.
Additional context
^current master