Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prying furniture / terrain doesn't show "failure": message #59044

Open
LyranRenegade opened this issue Jul 7, 2022 · 3 comments · May be fixed by #77251
Open

Prying furniture / terrain doesn't show "failure": message #59044

LyranRenegade opened this issue Jul 7, 2022 · 3 comments · May be fixed by #77251
Labels
<Bug> This needs to be fixed Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Info / User Interface Game - player communication, menus, etc. (S2 - Confirmed) Bug that's been confirmed to exist

Comments

@LyranRenegade
Copy link
Contributor

Describe the bug

When failing a prying check of furniture it doesn't show the "failure" message as defined in the json.
I don't know if this is the case for all items, but for the custom furniture, terrain I made it's always the case [so never any failure message].
It is also the case with the few vanilla-items i tested:
terrain: t_door_locked_interior
furniture: f_coffin_c

Steps to reproduce

spawn a closed coffin, try to pry it open with a low-strength character and fail.
no "You pry, but the coffin remains closed." message is shown.

Expected behavior

i expect the failure message to show

Screenshots

No response

Versions and configuration

win 7,
version: 5d5d5bd (tiles)
experimental from 2022-07-04

Additional context

No response
@LyranRenegade LyranRenegade added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Jul 7, 2022
@PatrikLundell
Copy link
Contributor

My current, strong, character occasionally fails to pry open crates with no failure message. My experimental version is a couple of weeks old, and I think this behavior has been present for quite some time before that.

@Night-Pryanik Night-Pryanik added <Bug> This needs to be fixed Info / User Interface Game - player communication, menus, etc. (S2 - Confirmed) Bug that's been confirmed to exist Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. and removed (S1 - Need confirmation) Report waiting on confirmation of reproducibility labels Jul 8, 2022
@Night-Pryanik
Copy link
Contributor

I found the culprit, it's these lines:

Cataclysm-DDA/src/activity_actor.cpp

Lines 4866 to 4870 in 414c57e

auto handle_failure = [&]( const pry_data & pdata ) -> void {
if( !pdata.breakable )
{
return;
}

They were added in #51778.
breakable field isn't set for majority of terrain/furniture, and because it's set to false by default, the handle_failure function, which should print the failure message, exits very early without printing anything.

@LyranRenegade
Copy link
Contributor Author

awesome!
Would the duration-tag doing nothing in some cases be related to this maybe? (#59045)

@Night-Pryanik Night-Pryanik linked a pull request Oct 22, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
<Bug> This needs to be fixed Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Info / User Interface Game - player communication, menus, etc. (S2 - Confirmed) Bug that's been confirmed to exist
Projects
None yet
Milestone
No milestone
3 participants
@Night-Pryanik @PatrikLundell @LyranRenegade