Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vehicle owner not set for appliances until you try to drag them. #77209

Open
sparr opened this issue Oct 21, 2024 · 0 comments · May be fixed by #77211
Open

Vehicle owner not set for appliances until you try to drag them. #77209

sparr opened this issue Oct 21, 2024 · 0 comments · May be fixed by #77211
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility

Comments

@sparr
Copy link
Member

sparr commented Oct 21, 2024

Describe the bug

When an appliance is placed, it has a null owner. This causes some misbehavior such as zones refusing to attach to cargo appliances like fridges. Attempting to drag the vehicle sets the owner to your followers.

Attach save file

N/A

Steps to reproduce

  1. start new game
  2. debug spawn item "household fridge"
  3. Construct terrain
  4. Place Household Fridge
  5. place it
  6. zone manager
  7. add zone
  8. Basecamp: Food
  9. set the start and end tile both on the fridge
  10. observe no zone vehicle cargo prompt
  11. Grab the fridge
  12. Grelease the fridge
  13. repeat 6-9
  14. prompt appears

Expected behavior

prompt to attach zone to vehicle cargo part should appear the first time, not just after the grab and release (which I suspect fixes the ownership around the time it does the theft check)

Screenshots

No response

Versions and configuration

  • OS: Linux
    • OS Version: LSB Version: n/a; Distributor ID: EndeavourOS; Description: EndeavourOS Linux; Release: rolling; Codename: rolling;
  • Game Version: 9e88c2a-dirty [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Portal Storms Ignore NPCs [personal_portal_storms],
    Slowdown Fungal Growth [no_fungal_growth]
    ]

Additional context

At

if( vp && vp->vehicle().get_owner() == fac && vp.cargo() ) {
vp->vehicle().get_owner() produces... I think the literal string "null" but I forgot to record it while debugging.

@sparr sparr added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Oct 21, 2024
@sparr sparr linked a pull request Oct 21, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant