Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCP redirection guide #360

Merged
merged 11 commits into from
Aug 26, 2024
Merged

TCP redirection guide #360

merged 11 commits into from
Aug 26, 2024

Conversation

Dekabry
Copy link
Contributor

@Dekabry Dekabry commented Aug 20, 2024

Describe your PR

Added guide to explain how to enable TCP redirection on the console.
Reworked some explanations.
Improved overall structure/style for readability.

Checklist

Reviewers

Who should review these changes? @cnivolle @juliamrch

Copy link

Deployment has finished 👁️👄👁️ Your app is available here

@juliamrch
Copy link
Collaborator

Thanks for this PR @Dekabry, I will check it out

@juliamrch juliamrch added the documentation Improvements or additions to documentation label Aug 20, 2024
Copy link
Collaborator

@juliamrch juliamrch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, see suggestions according to editorial linter.

content/doc/administrate/tcp-redirections.md Outdated Show resolved Hide resolved
content/doc/administrate/tcp-redirections.md Outdated Show resolved Hide resolved
content/doc/administrate/tcp-redirections.md Outdated Show resolved Hide resolved
content/doc/administrate/tcp-redirections.md Outdated Show resolved Hide resolved
content/doc/administrate/tcp-redirections.md Outdated Show resolved Hide resolved
content/doc/administrate/tcp-redirections.md Outdated Show resolved Hide resolved
content/doc/administrate/tcp-redirections.md Outdated Show resolved Hide resolved
content/doc/administrate/tcp-redirections.md Outdated Show resolved Hide resolved
content/doc/administrate/tcp-redirections.md Outdated Show resolved Hide resolved
content/doc/administrate/tcp-redirections.md Outdated Show resolved Hide resolved
Reformulating quite a lot of things :)

Co-authored-by: Julia March <[email protected]>
Co-authored-by: Clément Nivolle <[email protected]>
Copy link

🚀 You updated your review app. Check it here

@juliamrch
Copy link
Collaborator

juliamrch commented Aug 22, 2024

Assigned @Keksoj and/or @Wonshtrum to review the content.

This is the preview: http://documentation-pr-360.cleverapps.io/doc/administrate/tcp-redirections/

content/doc/administrate/tcp-redirections.md Outdated Show resolved Hide resolved
content/doc/administrate/tcp-redirections.md Outdated Show resolved Hide resolved
Copy link

@Wonshtrum Wonshtrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, but some paragraph seem to have been left from the old version and should be deleted. I think some parts could be reworked a little too.

content/doc/administrate/tcp-redirections.md Outdated Show resolved Hide resolved
content/doc/administrate/tcp-redirections.md Outdated Show resolved Hide resolved
content/doc/administrate/tcp-redirections.md Outdated Show resolved Hide resolved
content/doc/administrate/tcp-redirections.md Outdated Show resolved Hide resolved
content/doc/administrate/tcp-redirections.md Outdated Show resolved Hide resolved
content/doc/administrate/tcp-redirections.md Outdated Show resolved Hide resolved
content/doc/administrate/tcp-redirections.md Outdated Show resolved Hide resolved
content/doc/administrate/tcp-redirections.md Outdated Show resolved Hide resolved
content/doc/administrate/tcp-redirections.md Outdated Show resolved Hide resolved
content/doc/administrate/tcp-redirections.md Outdated Show resolved Hide resolved
content/doc/administrate/tcp-redirections.md Outdated Show resolved Hide resolved
content/doc/administrate/tcp-redirections.md Outdated Show resolved Hide resolved
content/doc/administrate/tcp-redirections.md Outdated Show resolved Hide resolved
Copy link

🚀 You updated your review app. Check it here

Keksoj
Keksoj previously approved these changes Aug 23, 2024
Wonshtrum
Wonshtrum previously approved these changes Aug 23, 2024
Copy link
Collaborator

@juliamrch juliamrch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small syntax improvements and it should be good to go

@Dekabry Dekabry dismissed stale reviews from Wonshtrum and Keksoj via 3b58303 August 26, 2024 13:03
Copy link

🚀 You updated your review app. Check it here

@Dekabry Dekabry requested a review from juliamrch August 26, 2024 13:05
Copy link

🚀 You updated your review app. Check it here

@juliamrch juliamrch merged commit 9e25576 into main Aug 26, 2024
3 checks passed
@juliamrch juliamrch deleted the TCP_redir branch August 26, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Development

Successfully merging this pull request may close these issues.

5 participants