Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stream backup download #871

Closed
wants to merge 2 commits into from
Closed

Stream backup download #871

wants to merge 2 commits into from

Conversation

Falinor
Copy link
Contributor

@Falinor Falinor commented Jan 14, 2025

Allow downloading large backup files by streaming the response body.
Replaces superagent by fetch as suggested by @hsablonniere in #597.

@Falinor Falinor requested a review from a team as a code owner January 14, 2025 23:40
@Falinor Falinor mentioned this pull request Jan 14, 2025
Open
@hsablonniere
Copy link
Member

Thanks very much for this @Falinor we'll review this PR in the following weeks and we added it to the scheduled next release 👍 😍

@hsablonniere hsablonniere added this to the 3.12 milestone Jan 23, 2025
pdesoyres-cc
pdesoyres-cc approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@pdesoyres-cc pdesoyres-cc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I've tested on small and large (1Gb) backups and it works fine.

Thank you @Falinor.

@Falinor Falinor mentioned this pull request Feb 26, 2025
Draft
@hsablonniere hsablonniere modified the milestones: 3.13, 3.12 Feb 27, 2025
@hsablonniere
Copy link
Member

@Falinor Thanks again for you contribution 👍 The way you used the streams is really nice 😉

Not a big deal, but sorry I misclicked on the GitHub rebase button and added a merge commit on your fork.

I just merged your PR manually with 08d3237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aurrelhebert aurrelhebert aurrelhebert approved these changes

@pdesoyres-cc pdesoyres-cc pdesoyres-cc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.12
Development

Successfully merging this pull request may close these issues.
4 participants
@Falinor @hsablonniere @aurrelhebert @pdesoyres-cc