Updated packages

[PasiVuohijoki]

Excplicitly added crossOrigin={undefined} into dateinput form field to make typescript compiler happy
Added resolver to prevent @react/types version 18 to be used. It breaks quite a lot of components currently

[EmiliaMakelaVincit]

I could test this but I think the point has been lost a bit here. I see no changes to our main dependency versions in package.json itself, so I assume this patch is only applying the latest hotfix/minor versions and not actually bringing our dependencies fully up to date.

[EmiliaMakelaVincit]

This review is only for the actual code part. While I did verify I could get the UI up after installing Node 18, my hands-on testing was somewhat limited today, but I'll go through all the key flows in detail on Monday.

This generally looks good. I think most of my comments were on shortcuts on issues I know to be difficult to fix, and it's likely fine to keep them as they are, just with the justification made clear in the context of that fix.

[EmiliaMakelaVincit]

I added two clarification comments to the previous set in the morning, and from the hands-on test I have two more things to mention:

• This warning gets sent into the console log: createSlice.ts:335 The object notation for createSlice.extraReducers is deprecated, and will be removed in RTK 2.0. Please use the 'builder callback' notation instead: https://redux-toolkit.js.org/api/createSlice. Do you think this is something that could also be changed in this update (or a follow-up)? It is related to updated packages, but I don't know how much work it'd be to fix now.
• The maximum height of the map component in the two map views needs to be adjusted, as with the new taller header the layers button gets "hidden" a scroll away once again even though it was fixed before.

[EmiliaMakelaVincit]

Oh, third point I just discovered: The popup that appears after you select a target still assumes that the header is sticky even though it isn't. If the page has been scrolled, it floats at an awkward distance from the top of the page.

[EmiliaMakelaVincit]

Once again, here's the code-side review for now, and the hands-on review will come a bit later. Seemed pretty good, half of my comments were questions that are likely fine as is already.

[EmiliaMakelaVincit]

From the last hands-on test, these haven't been changed:

• The map view height hasn't been adjusted; the layer selection button and the bottom of the view are still a scroll away when at the top of the page
• No change or comment was made towards the awkward positioning of the toast popup

One new observation from this round:

• Leaflet related button icons aren't showing up for me (Leaflet's map layer button, as well as all leaflet-draw button icons). It seems that the locations are compiled to be relative and resolve to start from the initial path on page load, as the file for the former is being looked up from "http://localhost:4000/aluehaku/hakemus/images/layers-2x.png" for instance if I reload on the first stage of area search flow.

[EmiliaMakelaVincit]

Looks good to go 🎉