ISN Fabric Support for dcnm_fabric module. #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CODE FUNCTIONAL CHANGES
plugins/module_utils/fabric/fabric_types.py
- Add changes for ISN fabric
DOCUMENTATION
dcnm_fabric.py
- Update documentation to include ISN fabric type
docs/cisco.dcnm.dcnm_fabric_module.rst
- Update with ISN fabric type
docs/cisco.dcnm.dcnm_maintenance_mode_module.rst
- This was missing. Adding it as part of this commit...
README.md
- Add dcnm_maintenance_mode link
INTEGRATION TESTS
playbooks/roles/dcnm_fabric/dcnm_tests.yaml
- Added IT for ISM delete, merged, replaced
tests/integration/targets/dcnm_fabric/tests/*.yaml
- Added the following tests
- dcnm_fabric_deleted_basic_isn.yaml
- dcnm_fabric_merged_baeic_isn.yaml
- Modified the following tests (tests were modified to include ISN)
- dcnm_fabric_deleted_basic.yaml
- Modified the following tests (only comments are modified)
- dcnm_fabric_deleted_basic_ipfm.yaml
- dcnm_fabric_deleted_basic_lan_classic.yaml
- dcnm_fabric_deleted_basic_vxlan.yaml
Fix sanity test errors. NETFLOW_*_LIST parameters needed "elements: str"
allenrobel
changed the title
allenrobel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR, when merged, provides support for the ISN (Inter-Site Network) fabric type (also known as Multi-Site External Network).
Branch
fabric_isncreated off of branchdevelopCODE FUNCTIONAL CHANGES
plugins/module_utils/fabric/fabric_types.py
- Add changes for ISN fabric
DOCUMENTATION
dcnm_fabric.py
docs/cisco.dcnm.dcnm_fabric_module.rst
docs/cisco.dcnm.dcnm_maintenance_mode_module.rst
README.md
INTEGRATION TESTS
playbooks/roles/dcnm_fabric/dcnm_tests.yaml
tests/integration/targets/dcnm_fabric/tests/*.yaml
Modified the following tests (tests were modified to include ISN)
Modified the following tests (only comments are modified)
UNIT TESTS