Skip to content

fix(file): delete physical cache files when removing documents #807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
majiayu000 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(file): delete physical cache files when removing documents #807

majiayu000 wants to merge 1 commit into from

Conversation

@majiayu000
Copy link

@majiayu000 majiayu000 commented Dec 27, 2025

Summary

  • Add _delete_physical_files method to clean up cache files on document deletion
  • Delete chunk cache files from KH_CHUNKS_OUTPUT_DIR
  • Delete markdown cache files from KH_MARKDOWN_OUTPUT_DIR
  • Graceful error handling to prevent deletion failures from blocking the operation

Test plan

  • Added unit tests for cache file deletion scenarios
  • Tests cover: file deletion, directory deletion, empty filename, missing dirs

Fixes #717

@majiayu000
fix(file): delete physical cache files when removing documents
f44d960 
Fixes Cinnamon#717

When deleting documents via the UI, the deletion now also removes:
- Chunk cache files from KH_CHUNKS_OUTPUT_DIR
- Markdown cache files from KH_MARKDOWN_OUTPUT_DIR

This prevents storage bloat from orphaned cache files that were
previously left behind after document deletion.

Signed-off-by: majiayu000 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] Physical Files Not Deleted When Removing Documents via UI

1 participant

@majiayu000