fix(chat): sync language setting with user preferences on login #804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When users sign in, the chat page now loads their saved language preference from the Reasoning settings. Previously, the language dropdown always reset to English on page reload. Changes: - Add _load_user_language() to fetch user's language from database - Subscribe to onSignIn event to update language dropdown - Reset language to default on sign out Fixes Cinnamon#692, Cinnamon#709 Signed-off-by: majiayu000 <[email protected]>
Add tests to verify language settings synchronization behavior: - Returns default language when no user is logged in - Returns saved language from user preferences - Returns default when no preference is saved - Properly resets language on sign out Signed-off-by: majiayu000 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
libs/ktem/ktem/pages/chat/__init__.py:_load_user_language()to fetch user's language from databaselibs/ktem/ktem_tests/test_language_settings.py: Added unit testsTest Plan
Fixes #692, #709
Signed-off-by: majiayu000 [email protected]