fix: use correct wording for HTTP status codes#778
Open
Lightning00Blade wants to merge 1 commit intomainfrom
Open
fix: use correct wording for HTTP status codes#778Lightning00Blade wants to merge 1 commit intomainfrom
Lightning00Blade wants to merge 1 commit intomainfrom
Conversation
| ? `[success - ${responseStatus}]` | ||
| : `[failed - ${responseStatus}]`; | ||
| } else if (failure) { | ||
| if (failure) { |
Collaborator
Author
There was a problem hiding this comment.
Moved failure first because if we have this text should be more helpful than the status code.
Collaborator
Author
There was a problem hiding this comment.
Maybe we need add the status code if it exist in this branch as well.
Collaborator
There was a problem hiding this comment.
I am in favour of a regular structure. It is not like if the failure comes first the LLM would necessarily pay more attention (might be quite the opposite)
OrKoN
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should match what the HTTP status codes are done in normal scenarios as this may confuse the AI.
https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Status