Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WinUtil Crashing on Startup - Xaml Error from Generated Applications List #2361

Merged

Conversation

og-mrk
Copy link
Contributor

@og-mrk og-mrk commented Jul 15, 2024

Description

This will fix WinUtil refusing to startup issue, giving an Xaml Syntax error.

At first I thought it's from your new Easter Egg.. cogh.. but after literally staring at the screen for 10 minute 😆 (just looking for syntax errors in your changes).. I was stuck to no avail ...

but at last, and by using a similar technique I've used before in PR #1850 (going through commit history, one commit at a time).. I've found the root cause of this issue (in PR #2316), which's the App Name Entry having a dash/minus symbol.. I'm just astounded on how it came to be, and how it passed the testing pipeline, but it was simple fix nonetheless.

Issue related to PR

Additional Information

We should try avoiding this issue by updating the docs to tell people not to add specific symbols in Field Names, and make the testing pipeline handle such situations without ignoring them.

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • My changes generate no errors/warnings/merge conflicts.

Copy link
Owner

@ChrisTitusTech ChrisTitusTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @og-mrk I think I'm going to shutdown application additions from new contributors as these are a pain to look for.

@ChrisTitusTech ChrisTitusTech merged commit 8340aca into ChrisTitusTech:main Jul 15, 2024
@og-mrk og-mrk deleted the fix-winutil-crashing-24-07-15 branch July 15, 2024 04:13
@ChrisTitusTech ChrisTitusTech added the skip-changelog Skip Change Logs label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skip Change Logs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WinUtil Crashing on Startup with Xaml Syntax Error - the version found on 'main' branch
2 participants