-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: apt-get with nala and hardcoded package managers #422
Conversation
And again you're literally just putting my changes into this one @jeevithakannan2 as seen with the commits before 100fc58 this one was incomplete... You shouldn't lie..
|
100fc58
to
8df764a
Compare
Go on and spam in other people PR's after copying them |
|
|
No, not exactly, I had missed those but my original implementation was correct, and BTW you shouldn't blatantly take my semi-complete fix and put it into a half baked PR.. And then start an argument over it after taking everything that was in my PR that fixed everything in this.. Here are the commits before & after you blatantly lied: before: 61cddeb after: 100fc58 |
Done with you do as you wish |
You're still missing some stuff that is correctly implemented in my 3 PRs, and you're modifying the aurhelpers when that wont be needed with #382 . Lets stop arguing over this nonsense... Just close this as its incomplete. @jeevithakannan2 |
I don't understand what you're calling incorrect in my PR and correct in yours?? |
Is this enough? |
@jeevithakannan2 Please man stop arguing with us, we have proved you wrong many times over. Just close this... |
Pull Request
Title
Use nala , replace hardcoded package managers, add missing checkEnv and checkEscalationTool, implement posix recommended way of using variables
Type of Change
Description
PACKAGER
variablecheckEnv
in numlock for consistency among scriptscheckEscalationTool
in monitor control for consistency among scriptsgaming-setup.sh
#380Issue related to PR
Testing
Additional Information
Warning
#440 #442 #443 are implemented after this PR. Check those PRs with mine and decide which one to merge
Caution
The implementation of #440 is wrong
Replacing apt-get with apt is not recommended when using in scripts.
Only if we switch nala and apt-get places in common script it will check for nala first if found it will choose nala as the package manager.
If not it will check for apt-get. On his implementation it will use apt itself as it checks for apt first.
Checklist