Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add wrapper around script #388

Merged
merged 3 commits into from
Sep 19, 2024

Conversation

jeevithakannan2
Copy link
Contributor

@jeevithakannan2 jeevithakannan2 commented Sep 15, 2024

Pull Request

Title

Add a wrapper around the script to prevent execution when partially downloaded.

Type of Change

  • Bug fix

Description

Don't depend on the user to use the correct flags for curl to protect against partial downloads.

The Nix package manager install script does the same:
https://nixos.org/nix/install

Issue related to PR

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no errors/warnings/merge conflicts.

Copy link
Contributor

@nnyyxxxx nnyyxxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

startdev.sh Show resolved Hide resolved
start.sh Show resolved Hide resolved
start.sh Outdated Show resolved Hide resolved
startdev.sh Outdated Show resolved Hide resolved
start.sh Outdated Show resolved Hide resolved
startdev.sh Outdated Show resolved Hide resolved
@ChrisTitusTech ChrisTitusTech merged commit 0453721 into ChrisTitusTech:main Sep 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrap start.sh code in curly braces to protect against partial downloads
3 participants