fix: Fixup preview rendering and logic of preview key binding being shown in shortcut list #387
+15
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixup rendering of floating text and logc of preview key binding being shown in shortcut list
Type of Change
Description
Any floating content that gets rendered has the possibility of rendering any text from the underlying widget. Prior to drawing the float content, the area that the float content is rendered to should be cleared prior to drawing the float content.
Impact
Having extraneous text present within the preview area might confuse users if the text that is presented from the underlying widget looks like valid bash. This removes the possibility for confusion.
Also, the key binding for showing the preview isn't rendered if the list widget is at the top-level dir of a category, but is properly shown in subdirs. The previewing capability is pretty nifty and should be properly displayed as a key binding when valid.
Issue related to PR
Checklist