Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework aurhelper functionality #382

Closed
wants to merge 5 commits into from

Conversation

nnyyxxxx
Copy link
Contributor

@nnyyxxxx nnyyxxxx commented Sep 14, 2024

Merge #282 before this!! very important!!

Type of Change

  • New feature
  • Refactoring

Description

Check this out Chris!

I'd recommend trying it out before merging just to see if you like it or not (the prompt is ugly ik, we could probably add some sort of color to it and format it differently).

Information

  • The prompt could get reworked if this gets merged, I don't have any ideas right now so I'll make a PR if this one gets merged.
  • This includes functionality for not just installing an AUR helper through aurhelper-setup.sh but also everywhere that checkAURHelper is! I know you'll love this feature Chris!
  • The installation of AUR Helpers only gets called if there are no AUR Helpers on the system (Paru, Yay) && the packager is pacman.

Testing

Tested.

Impact

Minimizes code, minimizes files, creates a interactive prompt for the user to select which aur helper to install all in 1 script.

Issue related to PR

Additional Information

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no errors/warnings/merge conflicts.

This was referenced Sep 14, 2024
#!/bin/sh -e

. ../../common-script.sh

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert functionality could be added inside of this script. Check out #384

@ChrisTitusTech
Copy link
Owner

I don't want to combine these and want minimal bash prompts and just install the program.

@nnyyxxxx nnyyxxxx deleted the testing-13 branch September 18, 2024 19:12
@ghost ghost mentioned this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants